Re: Forcing button icons (Re: Appearance properties)

[Tristan Van Berkom <tvb gnome org>]

On Mon, Nov 16, 2009 at 3:35 PM, Andre "Osku" Schmidt
<andre osku schmidt osku de> wrote:
> On Mon, 2009-11-16 at 13:02 -0200, Tristan Van Berkom wrote:
>> Just to be sure.. are you declaring your button as a stock
>> button with stock ids for the play pause buttons ?
>>
>> ... or are you using a button with GtkImage set explicitly
>> from Glade ?
>
> screenshot1(+b).png is with "label with optional image"
> screenshot2.png is with "stock button" (this used to work)
>
> in both cases there is no icon displayed.
>
> ok, it seems "custom button content" (hups, didn't notice this option
> before, sorry) seems to work. is this the recommended way ?
>

I would really rather not, Custom button content should really be for
cases where you need to customize - Originally I put that option
there because there was no way to assign a custom label/image
in a button (Glade-2 did something similar, only it exposed the
option and saved the file with an added GtkHBox/GtkAlignment
to position the label and image properly).

This activity of setting up an HBox/Alignment manually for your
button involves trying to mimic the spacing/alignment of a GtkButton which
could even change in the future, leaving your application looking awkward
with custom buttons grouped along with normal ones.

Well, after reading this:
   http://library.gnome.org/devel/gtk/stable/GtkButton.html#gtk-button-set-image

It seems like the "image" property of a GtkButton is ignored in the case
of "gtk-button-images = FALSE"

It seems that I've been happily unaware of this feature in GTK+ for some
years, since I have never encountered a desktop with this setting set
to FALSE, and it seems nobody else ever has either - or I would expect
to have received bug reports in Glade about this confusion by now.

Anyway, I have to say I'm a bit peeved about this policy of stomping on
the _explicitly_user_assigned_ GtkButton:image-widget property for the sake of
some desktop setting, returning a stock button with or without an
image based on
that criteria might have been more acceptable, since the definition of what a
stock button is, is left up to GTK+.

Actually I was really happy to see the addition of the "image-widget"
and "image-position" properties, but it seems that that is all just dead-code,
if the image-position/image-widget cant be used with the obscure setting
set to FALSE, and now with the setting default to FALSE, its just useless :(
(what a shame that I even spent time to expose those properties in a nice
way from the Glade GUI).

What am I expected to do, if Im expected to do anything about it at all;
just put some kind of big fat warning in Glade telling the user that "image"
and "image-position" properties are only useful on some remaining systems
that dont muck about with this "gtk-button-images" setting ?

Man the way information flows around here... we are obviously not... a team.

Cheers to a new graveyard in gtkbutton.c...

Regards,
           -Tristan