[Cowbell] Re: Cowbell Patches

> > Actually, any signals that were hooked up in the glade weren't meant to
> > be there; we actually hook these up in code.
> > 
> Ok. I was actually planing on auto connecting these so we don't have to
> do it in the code :-)

Autoconnecting signals with glade is *BAD*.  It makes much more sense to
see the signal hook up in the file and be able to reference it easily
and quickly than to have some strange, out of nowhere callback doing
important business.  Also it keeps the files required to change the name
of a method to a minimum.  Besides, Glade just sucks as an application.
Libglade on the other hand is much saner.

> > I kind of like this at 12... it keeps it consistent with the
> > PreferencesWindow.
> > 
> You forget that the action area in a GtkDialog has a border too. The
> dialog should actually have a border of 7 px, since the border of the
> action area is 5 px, and not 6 px as I first thought. 

Hmm, I've never been one to add borders to action areas.  However, if
you can find a HIG reference for this one, I'll let it slide.

> > Index: resources/MainWindow.glade
> > ===================================================================
> > --- resources/MainWindow.glade  (revision 225)
> > +++ resources/MainWindow.glade  (arbetskopia)
> > @@ -8,8 +8,8 @@
> >    <property name="type">GTK_WINDOW_TOPLEVEL</property>
> >    <property name="window_position">GTK_WIN_POS_NONE</property>
> >    <property name="modal">False</property>
> > -  <property name="default_width">700</property>
> > -  <property name="default_height">500</property>
> > +  <property name="default_width">600</property>
> > +  <property name="default_height">375</property>
> > 
> > I don't agree with this change.  When importing more than 11 songs (a
> > typical album has 12 songs), the window becomes too small to hold
> > everything easily.
> > 
> Sorry, I forgot about different font sizes. When using a font size of 8,
> it feels to big and obviously it's too small using larger fonts, so I
> changed the default size to 700x450, which seems to be a good
> compromise.

Okay, I'm down with that.

> > Also, I don't really agree with the spacing changes either.  It seems
> > like you're trying to get Cowbell to run on a 640x480 monitor -- is this
> > true?
> Most applications use a horizontal spacing of 12 (as specified by the
> HIG) and a vertical spacing of 6. Since I have no strong feelings about
> this I changed it back to 12.
> I have also added mnemonics to the labels in the main window.

Okay, the more mnemonics the better.

Everything else looks great.  If you make those changes, I'll try to get
your patch in in the next release.

Thanks again,


Brad Taylor
Genome Software LLC

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]