Re: Conduit code submission

On Fri, Oct 17, 2008 at 4:16 AM, James Ralston <jralston mindspring com> wrote:

Hi James, thanks for your mail

I'd like to submit some changes that I made to  I've
added the ratings, play-count, and (partial) cover-location tags to the

Cool, that is good to hear.

I know that there is an ongoing D-Bus version of the module, but I
wasn't sure if it would work from the command line if Rhythmbox isn't
already running.  I couldn't get it to work even when it was
running...not a complaint...since the code is probably still in flux.

Yeah, the DBus stuff require some modifications to the Rhythmbox application, of which I am not sure about the status. I have cc'd alexandre who knows most about this part of the application.

My questions: Are you interested in the code changes? If so, should I
send the modified file (with the generated CHANGELOG file) straight to
you?  Or, is there another (preferred) method for patch/code

Usually the best way is to create a bug in bugzilla [1], and attach the patch to that bug. If you need any more help creating the patch, then let me know.

BTW, the modified code is based on SVN change set 1765 (Monday).

Thanks in advance,

P.S. I'm also considering writing a MusicFolderTwoWay.  I need it to
keep my mass storage device based phone synchronized and organized.  The
idea is to create <artist>/<album>/<tracks> folder structure from the
media tags. And, (optionally) create the original playlist (pls or m3u)
in the top level folder.

Thats a good idea. Alexandre, do you have any thoughts on this?



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]