[banshee] Revert "Banshee.Collection: refactoring around Unknown constant variables"
- From: Andrés Aragoneses <aaragoneses src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee] Revert "Banshee.Collection: refactoring around Unknown constant variables"
- Date: Thu, 5 Sep 2013 10:54:01 +0000 (UTC)
commit 5c8bb7a244afef8d8bec84615430f76e42f72f26
Author: Andrés G. Aragoneses <knocte gmail com>
Date: Thu Sep 5 12:52:20 2013 +0200
Revert "Banshee.Collection: refactoring around Unknown constant variables"
This reverts commit ce18689aa7919d888ebe1fd586d8c2adcf4395e0.
The calls to Catalog.GetString() cannot use variables instead of
immediate string values, because it is a requirement from the
gettext scanning tools for i18n.
.../Banshee.Core/Banshee.Collection/AlbumInfo.cs | 4 ++--
.../Banshee.Core/Banshee.Collection/ArtistInfo.cs | 4 ++--
.../Banshee.Core/Banshee.Collection/TrackInfo.cs | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/src/Core/Banshee.Core/Banshee.Collection/AlbumInfo.cs
b/src/Core/Banshee.Core/Banshee.Collection/AlbumInfo.cs
index f96000a..44124aa 100644
--- a/src/Core/Banshee.Core/Banshee.Collection/AlbumInfo.cs
+++ b/src/Core/Banshee.Core/Banshee.Collection/AlbumInfo.cs
@@ -37,8 +37,8 @@ namespace Banshee.Collection
{
public class AlbumInfo : CacheableItem
{
- public const string UnknownAlbumTitleUntranslated = "Unknown Album";
- public static readonly string UnknownAlbumTitle = Catalog.GetString (UnknownAlbumTitleUntranslated);
+ public static readonly string UnknownAlbumTitle = Catalog.GetString ("Unknown Album");
+ public static readonly string UnknownAlbumTitleUntranslated = "Unknown Album";
private string title;
private string title_sort;
diff --git a/src/Core/Banshee.Core/Banshee.Collection/ArtistInfo.cs
b/src/Core/Banshee.Core/Banshee.Collection/ArtistInfo.cs
index 7f236b1..50025b7 100644
--- a/src/Core/Banshee.Core/Banshee.Collection/ArtistInfo.cs
+++ b/src/Core/Banshee.Core/Banshee.Collection/ArtistInfo.cs
@@ -34,8 +34,8 @@ namespace Banshee.Collection
{
public class ArtistInfo : CacheableItem
{
- public const string UnknownArtistNameUntranslated = "Unknown Artist";
- public static readonly string UnknownArtistName = Catalog.GetString (UnknownArtistNameUntranslated);
+ public static readonly string UnknownArtistName = Catalog.GetString ("Unknown Artist");
+ public static readonly string UnknownArtistNameUntranslated = "Unknown Artist";
private string name;
private string name_sort;
diff --git a/src/Core/Banshee.Core/Banshee.Collection/TrackInfo.cs
b/src/Core/Banshee.Core/Banshee.Collection/TrackInfo.cs
index 2e85dd4..2014e72 100644
--- a/src/Core/Banshee.Core/Banshee.Collection/TrackInfo.cs
+++ b/src/Core/Banshee.Core/Banshee.Collection/TrackInfo.cs
@@ -46,8 +46,8 @@ namespace Banshee.Collection
public const string ExportVersion = "1.0";
public static readonly double PlaybackSkippedThreshold = 0.5;
- public const string UnknownTitleUntranslated = "Unknown Title";
- public static readonly string UnknownTitle = Catalog.GetString (UnknownTitleUntranslated);
+ public static readonly string UnknownTitle = Catalog.GetString ("Unknown Title");
+ public static readonly string UnknownTitleUntranslated = "Unknown Title";
public class ExportableAttribute : Attribute
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]