[gtk+] treednd: Remove (out) annotation for GtkSelectionData arg



commit 843e5f9cb304feeb1c8e3345729ed0ee1297c96c
Author: Torsten SchÃnfeld <kaffeetisch gmx de>
Date:   Wed Jan 30 00:11:29 2013 +0100

    treednd: Remove (out) annotation for GtkSelectionData arg
    
    gtk_tree_drag_source_drag_data_get's GtkSelectionData argument should not be
    marked as (out) because:
    
    a) GtkSelectionData is semi-private (it's declared in gtkselectionprivate.h),
    and thus gobject-introspection has no knowledge of its fields or its size.
    There is thus no way for language bindings to allocate GtkSelectionData.
    
    b) Even if it was possible for language bindings to allocate GtkSelectionData,
    a zeroed-out instance thus created would not be usable with
    gtk_tree_drag_source_drag_data_get.  As far as I can tell, you need to
    initialize its "target" member to the GdkAtom of "GTK_TREE_MODEL_ROW".
    Language bindings have no way of knowing this, of course.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=692844

 gtk/gtktreednd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtktreednd.c b/gtk/gtktreednd.c
index 56e2bb0..d65cdc0 100644
--- a/gtk/gtktreednd.c
+++ b/gtk/gtktreednd.c
@@ -157,7 +157,7 @@ gtk_tree_drag_source_drag_data_delete (GtkTreeDragSource *drag_source,
  * gtk_tree_drag_source_drag_data_get:
  * @drag_source: a #GtkTreeDragSource
  * @path: row that was dragged
- * @selection_data: (out): a #GtkSelectionData to fill with data
+ * @selection_data: a #GtkSelectionData to fill with data
  *                  from the dragged row
  * 
  * Asks the #GtkTreeDragSource to fill in @selection_data with a



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]