[caribou] key-model: Use key-released instead of key-clicked to hide subkeys



commit 134f3c399961d2dd5e38d17d22ed92f5c65c103a
Author: Rui Matos <tiagomatos gmail com>
Date:   Fri Nov 23 15:01:08 2012 +0100

    key-model: Use key-released instead of key-clicked to hide subkeys
    
    This allows users to insert subkeys with a single button press/release
    pair by pressing on the main key, then moving and releasing while
    hovering the subkey.
    
    Also, emit key-released instead of key-clicked on the main key since
    that is a better model of what is really happening.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688656

 libcaribou/key-model.vala |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/libcaribou/key-model.vala b/libcaribou/key-model.vala
index 017e046..f4f4c17 100644
--- a/libcaribou/key-model.vala
+++ b/libcaribou/key-model.vala
@@ -121,12 +121,12 @@ namespace Caribou {
         }
 
         internal void add_subkey (KeyModel key) {
-            key.key_clicked.connect(on_subkey_clicked);
+            key.key_released.connect(on_subkey_released);
             extended_keys.add (key);
         }
 
-        private void on_subkey_clicked (KeyModel key) {
-            key_clicked (key);
+        private void on_subkey_released (KeyModel key) {
+            key_released (key);
             show_subkeys = false;
         }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]