[gxml] * No, Iterators shouldn't cycle, which I mistakenly believed after discovering first had been remove
- From: Richard Hans Schwarting <rschwart src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gxml] * No, Iterators shouldn't cycle, which I mistakenly believed after discovering first had been remove
- Date: Fri, 15 Jun 2012 22:57:48 +0000 (UTC)
commit db8532332744a2c22239c7dfe274e7be2e09b84b
Author: Richard Schwarting <aquarichy gmail com>
Date: Fri Jun 15 18:57:41 2012 -0400
* No, Iterators shouldn't cycle, which I mistakenly believed after discovering first had been removed and reading the documentation for valid.
gxml/NodeList.vala | 20 +++-----------------
1 files changed, 3 insertions(+), 17 deletions(-)
---
diff --git a/gxml/NodeList.vala b/gxml/NodeList.vala
index 33cccd6..265233b 100644
--- a/gxml/NodeList.vala
+++ b/gxml/NodeList.vala
@@ -273,16 +273,10 @@ namespace GXmlDom {
return (this.next_node == null);
}
+ // TODO: address ambiguity of libgee documentation that led me to believe that a call to get needed to be valid in such a way that I had to cycle here.
protected override void advance () {
this.cur = this.next_node;
- if (this.cur.next != null) {
- this.next_node = this.cur.next;
- } else {
- // we're at the end of the list, reset
- this.next_node = this.first_node;
- /* TODO: we might not want to?
- maybe we just want it to end */
- }
+ this.next_node = this.cur.next;
}
/*** Traversable methods ***/
@@ -668,15 +662,7 @@ namespace GXmlDom {
protected override void advance () {
this.cur = this.next_node;
- if (this.cur->next != null) {
- this.next_node = cur->next;
- } else {
- /* TODO: We cycle back to the start, but
- perhaps we don't want to. The interface
- description implies that we should because
- we always want to point to something */
- this.next_node = this.head;
- }
+ this.next_node = cur->next;
}
/*** Traversable methods ***/
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]