[extensions-web] Explicitly make four-digit shell versions like "3.2.2.1" invalid



commit 9fbd617c41ca2252c0d9f3a42c39f8b7f2a8189c
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Tue Jan 31 13:43:52 2012 -0500

    Explicitly make four-digit shell versions like "3.2.2.1" invalid

 sweettooth/extensions/models.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/sweettooth/extensions/models.py b/sweettooth/extensions/models.py
index ff37dec..ec80b71 100644
--- a/sweettooth/extensions/models.py
+++ b/sweettooth/extensions/models.py
@@ -159,7 +159,7 @@ class InvalidShellVersion(Exception):
 
 class ShellVersionManager(models.Manager):
     def parse_version_string(self, version_string):
-        version = version_string.split('.', 2)
+        version = version_string.split('.')
         major, minor = version[:2]
 
         try:
@@ -167,7 +167,7 @@ class ShellVersionManager(models.Manager):
         except ValueError, e:
             raise InvalidShellVersion()
 
-        if len(version) >= 3:
+        if len(version) == 3:
             # 3.0.1, 3.1.4
             try:
                 point = int(version[2])



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]