[extensions-web] Raise "InvalidShellVersion" in more cases



commit 429ce929bd85c10fe0ddf643c4ed42e27d6b04ca
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Tue Jan 31 13:43:35 2012 -0500

    Raise "InvalidShellVersion" in more cases

 sweettooth/extensions/models.py |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)
---
diff --git a/sweettooth/extensions/models.py b/sweettooth/extensions/models.py
index ca4a758..ff37dec 100644
--- a/sweettooth/extensions/models.py
+++ b/sweettooth/extensions/models.py
@@ -161,11 +161,19 @@ class ShellVersionManager(models.Manager):
     def parse_version_string(self, version_string):
         version = version_string.split('.', 2)
         major, minor = version[:2]
-        major, minor = int(major), int(minor)
+
+        try:
+            major, minor = int(major), int(minor)
+        except ValueError, e:
+            raise InvalidShellVersion()
 
         if len(version) >= 3:
             # 3.0.1, 3.1.4
-            point = int(version[2])
+            try:
+                point = int(version[2])
+            except ValueError, e:
+                raise InvalidShellVersion()
+
         elif len(version) == 2 and minor % 2 == 0:
             # 3.0, 3.2
             point = -1



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]