[extensions-web] Ignore invalid shell versions when parsing metadata.json



commit fe8a67aa755689ff491c96dd7fbb11c52ddb9ef5
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Tue Jan 31 13:44:10 2012 -0500

    Ignore invalid shell versions when parsing metadata.json

 sweettooth/extensions/models.py |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/sweettooth/extensions/models.py b/sweettooth/extensions/models.py
index ec80b71..6e5b4d5 100644
--- a/sweettooth/extensions/models.py
+++ b/sweettooth/extensions/models.py
@@ -398,7 +398,13 @@ class ExtensionVersion(models.Model):
         self.save()
 
         for sv_string in metadata.pop('shell-version', []):
-            sv = ShellVersion.objects.get_for_version_string(sv_string)
+            try:
+                sv = ShellVersion.objects.get_for_version_string(sv_string)
+            except InvalidShellVersion:
+                # For now, ignore invalid shell versions, rather than
+                # causing a fit.
+                pass
+
             self.shell_versions.add(sv)
 
         self.save()



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]