[frogr] Don't unref the pixbuf when placing it into the list store.



commit e9504369a383fff7621f6d02fc4b33adaf415f13
Author: Mario Sanchez Prada <msanchez igalia com>
Date:   Sat Aug 27 21:29:35 2011 +0200

    Don't unref the pixbuf when placing it into the list store.
    
    This will cause memory corruption later on, since it will be already
    unreffed when removing it from the list store, but also when the
    associated FrogrPicture gets finalized.

 src/frogr-main-view.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/frogr-main-view.c b/src/frogr-main-view.c
index df44bc7..43d3252 100644
--- a/src/frogr-main-view.c
+++ b/src/frogr-main-view.c
@@ -784,7 +784,6 @@ _add_picture_to_ui (FrogrMainView *self, FrogrPicture *picture)
                       -1);
 
   g_object_ref (picture);
-  g_object_unref (pixbuf);
 
   /* Reorder if needed */
   if (priv->sorting_criteria != SORT_AS_LOADED || priv->sorting_reversed)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]