[rhythmbox] generic-player: don't crash saving empty playlists (bug #616538)
- From: Jonathan Matthew <jmatthew src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [rhythmbox] generic-player: don't crash saving empty playlists (bug #616538)
- Date: Thu, 22 Apr 2010 21:31:25 +0000 (UTC)
commit e7b3f41b9a7fda307e425f6d80d2f5689219420f
Author: Jonathan Matthew <jonathan d14n org>
Date: Fri Apr 23 07:27:05 2010 +1000
generic-player: don't crash saving empty playlists (bug #616538)
If we try to save an empty playlist, totem-pl-parser currently returns
FALSE without providing any error information, but we were expecting the
error information to be there.
.../rb-generic-player-playlist-source.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/plugins/generic-player/rb-generic-player-playlist-source.c b/plugins/generic-player/rb-generic-player-playlist-source.c
index 2c0ec4e..7be15f7 100644
--- a/plugins/generic-player/rb-generic-player-playlist-source.c
+++ b/plugins/generic-player/rb-generic-player-playlist-source.c
@@ -273,7 +273,7 @@ save_playlist (RBGenericPlayerPlaylistSource *source)
#endif
if (result == FALSE) {
/* XXX report this more usefully */
- g_warning ("Playlist save failed: %s", error->message);
+ g_warning ("Playlist save failed: %s", error ? error->message : "<no error>");
} else {
GFile *dest;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]