[orca] Fix for bgo#593596 - When the user Up Arrows to a line in Firefox which begins with a nested paragra
- From: Joanmarie Diggs <joanied src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [orca] Fix for bgo#593596 - When the user Up Arrows to a line in Firefox which begins with a nested paragra
- Date: Mon, 31 Aug 2009 01:30:47 +0000 (UTC)
commit 4e61c110d3939eca11c137f9912a199597792922
Author: Joanmarie Diggs <joanmarie diggs gmail com>
Date: Sun Aug 30 21:28:24 2009 -0400
Fix for bgo#593596 - When the user Up Arrows to a line in Firefox which begins with a nested paragraph, Orca fails to present that line
src/orca/scripts/toolkits/Gecko/script.py | 7 ++++++-
test/keystrokes/firefox/line_nav_bug_592383.py | 6 +++---
2 files changed, 9 insertions(+), 4 deletions(-)
---
diff --git a/src/orca/scripts/toolkits/Gecko/script.py b/src/orca/scripts/toolkits/Gecko/script.py
index 95b3d7b..1d890da 100644
--- a/src/orca/scripts/toolkits/Gecko/script.py
+++ b/src/orca/scripts/toolkits/Gecko/script.py
@@ -5528,7 +5528,12 @@ class Script(default.Script):
# the beginning of this line to that initial
# character, we'll get stuck. See bug 592383.
#
- pass
+ if end - start > 1 and end - offset == 1:
+ # We must be Up Arrowing. Set the offset to
+ # just past the EOC so that we present the
+ # line rather than saying "blank."
+ #
+ offset = start + 1
else:
# It's a link that ends on our left. Who knows
# where it starts? Might be on the previous
diff --git a/test/keystrokes/firefox/line_nav_bug_592383.py b/test/keystrokes/firefox/line_nav_bug_592383.py
index 2092752..4354d02 100644
--- a/test/keystrokes/firefox/line_nav_bug_592383.py
+++ b/test/keystrokes/firefox/line_nav_bug_592383.py
@@ -108,9 +108,9 @@ sequence.append(utils.StartRecordingAction())
sequence.append(KeyComboAction("Up"))
sequence.append(utils.AssertPresentationAction(
"2. Up",
- ["BUG? - We're skipping the line at the beginning of the paragraph",
- "BRAILLE LINE: ''",
- " VISIBLE: '', cursor=1"]))
+ ["BRAILLE LINE: 'Â Â Â hy did the chicken cross the road? Give up? It was to escape from the enormous capital letter at the beginning of this paragraph. These are the'",
+ " VISIBLE: 'Â Â Â hy did the chicken cross the ', cursor=1",
+ "SPEECH OUTPUT: 'Â Â Â hy did the chicken cross the road? Give up? It was to escape from the enormous capital letter at the beginning of this paragraph. These are the'"]))
sequence.append(utils.StartRecordingAction())
sequence.append(KeyComboAction("Up"))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]