On Di, 2009-05-26 at 09:26 +0200, Filippo Argiolas wrote: > On Mon, May 25, 2009 at 8:34 AM, Filippo Argiolas <fargiolas gnome org> wrote: > > On Sun, May 24, 2009 at 6:47 PM, daniel g. siegel <dgsiegel gnome org> wrote: > >> hey filippo! > > hey! > > > >> again, this is an awesome feature. it seems to work fine, i just have > >> some comments: > >> > >> * on start, i automatically get 2 small black borders on each side > >> with a resolution of 640x480. we should remove that. > > > > I tried but it's quite difficult. > > Should be fixed with commit > http://git.gnome.org/cgit/cheese/commit/?h=noflicker&id=229bc9c8c47eba2096cd7f4f32dd369d99e117bb > > It works pretty fine with 4:3 webcam resolution (640x480), no black > bars and no minimum size constrictions in the drawing area :) (Owen > deserves credits for the handy trick). > Doing it depending on the webcam resolution would be a bit more > difficult and would surely involve an initial size of the window and a > resize after webcam detection. It would quite ugly so I don't think > it's worth to look into this more. Maybe we can improve this a little > bit setting the aspect ratio to the one of the resolution saved in > gconf. > By the way, this partly solves the netbook bug too since he pushes a > lot down the minimum size of the window. > > So, ready for the merge? looks definitely more awesome ;) you should add the attached casting line, otherways it wont compile when you have enabled -Wall -Werror daniel > > ciao, > Filippo -- this mail was sent using 100% recycled electrons ================================================ daniel g. siegel <dgsiegel gmail com> http://home.cs.tum.edu/~siegel gnupg key id: 0x6EEC9E62 fingerprint: DE5B 1F64 9034 1FB6 E120 DE10 268D AFD5 6EEC 9E62 encrypted email preferred
diff --git a/src/cheese-window.c b/src/cheese-window.c
index ec287d5..10642f0 100644
--- a/src/cheese-window.c
+++ b/src/cheese-window.c
@@ -1996,7 +1996,7 @@ cheese_window_init (char *hal_dev_udi, CheeseDbus *dbus_server)
gtk_widget_set_size_request (cheese_window->screen,
DEFAULT_WINDOW_WIDTH, DEFAULT_WINDOW_HEIGHT);
gtk_widget_size_request (cheese_window->window, &req);
- gtk_window_set_default_size (cheese_window->window, req.width, req.height);
+ gtk_window_set_default_size (GTK_WINDOW (cheese_window->window), req.width, req.height);
gtk_widget_set_size_request (cheese_window->screen, -1, -1);
gtk_widget_show_all (cheese_window->window);
Attachment:
signature.asc
Description: This is a digitally signed message part