Re: [BuildStream] Deprecating docker plugin in bst-external

[Phil Dawson <phil dawson codethink com>]

Hi Jim,

At the moment there is a merge request [0] introducing a way to mark 
plugins as deprecated.

The current block on this MR is that I agreed with Juerg that the 
configuration key for suppressing these deprecation warnings should be 
moved from the top level to be a flag for each appropriate plugin in the 
plugin specific configuration overrides [1].

I've put that to one side while I work on other things which block the 
migration of plugins away from BuildStream core, but plan to come back 
to it later. In the meanwhile, I'm more than happy if someone else wants 
to pick it up.

[0] https://gitlab.com/BuildStream/buildstream/merge_requests/1057
[1] https://gitlab.com/BuildStream/buildstream/merge_requests/1057

Cheers,

Phil


On 15/02/2019 08:43, Jim MacArthur via BuildStream-list wrote:
> I would like to mark the docker source plugin in bst-external [1] as 
> deprecated.
>
> At the moment, it is deprecated, but there's no indication that it is 
> deprecated; it's been moved to the bst-plugins-container repository. I 
> worked with the old version for about a day; luckily, there haven't 
> been any changes since it was moved.
>
> Given the recent discussion about deprecating plugins [2] I'd like to 
> suggest that we make a standard warning token called "deprecated" for 
> plugins, so we at least have the chance to silence deprecation 
> warnings in future if we decide to go that way. I have no idea how we 
> actually record that standard in BuildStream yet.
>
> Other than that, if I just add a warning with that token and 
> appropriate text in bst-external's docker plugin, would anyone object?
>
> [1] 
> https://gitlab.com/BuildStream/bst-external/blob/master/bst_external/sources/docker.py
>
> [2] 
> https://mail.gnome.org/archives/buildstream-list/2018-November/msg00098.html
>
> _______________________________________________
> BuildStream-list mailing list
> BuildStream-list gnome org
> https://mail.gnome.org/mailman/listinfo/buildstream-list
--
Phil Dawson, Software Engineer                          Codethink Ltd
https://www.codethink.co.uk/
We respect your privacy. See https://www.codethink.co.uk/privacy.html