Re: [BuildStream] Proposal: Workspace related DX features & design




On Thu, Sep 6, 2018 at 12:54 PM Tristan Van Berkom <tristan vanberkom codethink co uk> wrote:
On Thu, 2018-09-06 at 12:40 +0200, Sander Striker wrote:
[...] 
> Syntax wise we could use '--directory' instead of '--path' since we
> already have one location where we are using it, which is bst source-
> bundle.  However..., it looks like we have --directory as a global
> option as well to specify the project directory, which is unfortunate
> duplication.
>
> Thoughts?
>

I am rather ambivalent on this point, `--directory` in this case is
fine by me, I think we we're mostly using `--path` in our conversation
to help disambiguate with the former proposal.

Specifying:

  bst --directory /path/to/project workspace open --directory ~/my_workspace

Does not look wrong to me, could be confusing to new users but, the
sooner they learn that placements of options after command names is
extremely significant, the better.

With our CLI semantics, the placement of options are entirely
significant, both `--directory` statements in the above are clearly
different enough in my opinion.

Alternatively, it could equally be `--location` or `--workdir`, if
people really want a different word.

Then let's just follow precedent (from bst source-bundle) to keep things consistent and stick with --directory.

Cheers,

Sander
 
Cheers,
    -Tristan

--

Cheers,

Sander


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]