Re: [BuildStream] Invalid characters for element names

[Chandan Singh <chandan chandansingh net>]

Hi all,

I have created https://gitlab.com/BuildStream/buildstream/merge_requests/1028
to define what constitutes a valid element name. This MR will make
BuildStream raise warnings when we find an invalid element, on a best
effort basis. It comes with an update to the documentation.

The set of allowed characters is: { printable 7-bit ASCII characters }
- { characters that are not allowed for filenames on Windows }

Any feedback will be appreciated.

Cheers,
Chandan

On Mon, Dec 10, 2018 at 10:17 AM Tristan Van Berkom via
BuildStream-list <buildstream-list gnome org> wrote:
> On Mon, 2018-12-10 at 10:54 +0100, Jürg Billeter wrote:
> [...]
> > The proposed subset includes characters that are not allowed on
> > Windows, though. Should we reduce the set of valid characters further
> > or shall we leave this up to individual projects (if/when we support
> > non-WSL Windows at all)?
>
> My 2 cents would be to reduce to a set of valid characters supported on
> all known platforms.
>
> I wouldn't go so far as reducing it to an 8.3 character filename length
> limit, but we probably aught to also consider a reasonable filename
> length limit while we're at it...
>
> Cheers,
>     -Tristan
>
> _______________________________________________
> BuildStream-list mailing list
> BuildStream-list gnome org
> https://mail.gnome.org/mailman/listinfo/buildstream-list