Re: port Brasero to opensolaris

[Lin Ma <Lin Ma Sun COM>]

Lin Ma wrote:
> Hello Philippe,
>
> Philippe Rouquier wrote:
> > Hi,
> >
> > Sorry, I didn't check bugzilla before posting a reply in the forum 
> > and apparently I should have since it seems you're well ahead of what 
> > I thought. 
> Thanks for your quick review. :-)
> I have another patch 542139 to make Brasero workable on Solaris. 
> Please review it.
> With the two patches, and some Solaris specific fixes I successfully 
> write a ISO to DVD, though there still have bugs.
> Forgot to mention that uscsi(7I) is compliant to ANSI Small Computer 
> System Interface-2 (SCSI-2). I will update it to 507141.
Nit, it's 542136. Sorry.

lin
> > I read your patches in bugzilla and they seem good to me. I intend to 
> > commit them to trunk tomorrow (that means they'll be included for 
> > next release). Now in bugzilla someone said brasero couldn't compile 
> > with solaris (see #507141 
> > <http://bugzilla.gnome.org/show_bug.cgi?id=507141> ). I was wondering 
> > if you could tell me what you think of his patch and if it's really 
> > needed (though I must confess some cleanups are needed in the 
> > headers). But maybe I'm wrong here and confuse solaris and open solaris.
> In comment#2, Luis has committed all the patches about GCC warning 
> arguments. I think it's fine to Solaris. About the inline functions, 
> actually Sun compiler v12 support it, v12 also support zero length 
> array, but doesn't support zero length structure unfortunately. While 
> Sun internal standard compiler is actually v11 which do not support 
> all above features.
>
> Leave it untouched is good to me. If Solaris doesn't upgrade to v12 
> internally I will create a internal patch for Brasero. But I hope 
> Brasero fans do not use zero length structures any more, please add 
> paddings if possible.
>
> Thanks,
> lin


--
x82120 / +86 10 82618200