[tim-janik/beast] Resampler cleanups (#125)

[Stefan Westerfeld <notifications github com>]

I cleaned up the resampling code:

• the C API was removed
• the implementation no longer relies on blockutils, but does its own SSE/FPU handling
• Resampler2::create() got an additional argument: true means SSE should be used if available; false means the FPU version should always be used
• FPU/SSE resampling is now under test again, I adapted some of the tests

Plugins (LadderFilter) for now can use Resampler2::create (..., false) to force using FPU resampling. As soon as the engine guarantees SSE-alignment of input/output blocks, this can be removed.

The old Makefile.am had more "testresampler" style tests, these could be added.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/125

Commit Summary

• BSE: Resampler: remove C API
• TESTS: resamplehandle: remove Resampler C API test
• BSE: no longer rely on block utils to create Resampler2 implementation
• TESTS: no longer rely on block utils to create Resampler2 implementation
• BSE: Resampler2: properly support SSE again
• TESTS: testresamplerq: re-enable SSE tests (and still do FPU tests)
• TESTS: resamplehandle: test both: SSE/FPU version for delay compensation
• TESTS: testresampler: re-enable tests for both: SSE and FPU Resampler

File Changes

• M bse/bseblockutils.cc (25)
• M bse/bseblockutils.hh (14)
• M bse/bseresampler.cc (86)
• M bse/bseresampler.hh (34)
• M bse/bseresamplerimpl.hh (14)
• M tests/resamplehandle.cc (55)
• M tests/testresampler.cc (92)
• M tests/testresamplerq.cc (36)

Patch Links:

• https://github.com/tim-janik/beast/pull/125.patch
• https://github.com/tim-janik/beast/pull/125.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.