Re: [Banshee-List] Ampache Extension

[Bertrand Lorentz <bertrand lorentz gmail com>]

On Fri, Oct 29, 2010 at 7:39 PM, Bertrand Lorentz
<bertrand lorentz gmail com> wrote:
> On Fri, Oct 29, 2010 at 3:08 AM, John Moore <jcwmoore gmail com> wrote:
>> I have put together an extension to allow Banshee to be a front for an
>> Ampache media server.  It's nothing overly complicated, simply lists
>> artists, albums, play lists and songs from Ampache and allows you to play
>> the songs. I would like to get the extension merged into the community
>> extensions and to get some feed back on the extension.  The source is
>> available in gitorious
>> <<http://gitorious.org/~jcwmoore/banshee-community-extensions/ampache-banshee-community-extensions>>
>> I'm not sure what is the preferred way to add an extension to the community
>> extensions project, or if there is one.  Any way the source is out there and
>> I'd appreciate any feed back or suggestions.  Thanks
>
> Cool, thanks for the heads up.
> I've just started a 4 day week-end, so I'll probably have a go at
> merging it into the main git repo in the coming days.
> The Makefile.am files seem to be outdated, but I'll probably be
> fiddling with the build anyway, so I'll fix it while I'm at it.
> I'll keep you posted if I have any other issues.

John,
I've just merged your extension into git master, and I've added you to
the banshee-community-extensions team on gitorious. You should now be
able to push your commits to the main repository.

I was too lazy too install an Ampache server, so I didn't test much of
the actual features : the extension loads and tries to connect, but I
couldn't go any further.

I've fixed a few small things here and there, but don't be afraid by
the number of lines I changed : for some reason a lot of the lines had
DOS endings, so I converted those to UNIX line endings.

A few random ideas/suggestions that crossed my mind :
1/ The URLs used assume that the Ampache server is always accessed as
http//servername/ampache/...
I'm not sure it's always the case, some people might use another
prefix : http//servername/music/...

2/ Maybe it would be better to put the connection info (server, user
and password) as preferences for the Ampache source. The idea is to
have something similar to what the Last.fm extension does. This would
free up some space in the UI.

3/ The extension is using a TreeView to display the track list. I
wonder if it would be possible to use our custom ListView widget
instead ?


Thank you for working on this extension, and I'm looking forward to
future improvements !

-- 
Bertrand Lorentz