[Banshee-List] Looking for help completing l10n in clickable TrackInfoDisplay patch (bug #428849)



Hey folks,

A long time ago I started work [1] on a patch to make the
TrackInfoDisplay interactive [2], letting you single-click on artist
or album info to perform searches, or right-click to get options like
adding to the queue.

I have had basically no time to work on this for months, and would
love for somebody to finish the one remaining task: l10n.

Basically, if you look at the latest version of the patch [3], you'll
see see stuff like:

-                // Translators: {0} and {1} are for markup so ignore
them, {2} and {3}
-                // are Artist Name and Album Title, respectively;
-                // e.g. 'by Parkway Drive from Killing with a Smile'
-                markup = MarkupFormat (Catalog.GetString ("{0}by{1}
{2} {0}from{1} {3}"), display_artist, display_album);
+                phrases.Add (new TrackInfoPhrase (Catalog.GetString
("by"), TrackInfoProperty.None));
+                phrases.Add (new TrackInfoPhrase (display_artist,
TrackInfoProperty.ArtistName));
+                phrases.Add (new TrackInfoPhrase (Catalog.GetString
("from"), TrackInfoProperty.None));
+                phrases.Add (new TrackInfoPhrase (display_album,
TrackInfoProperty.AlbumName));

Notice that in the original version, translators manipulated an entire
string, allowing them to affect the order of the by/from phrase.  But
with my changes that split up all of this info (so that some elements
can be clickable), that reordering capability is lost, and we end up
forcing English-like word order.

This could probably be fixed by creating a markup string much like the
one removed in this patch snippet, and then using that markup string
to determine word order when actually putting the by/from phrase on
the GUI.

Anyway, I don't have time to work on this, and I think this feature is
super-useful and don't want it to get lost.  Is anybody interested in
adding the finishing touches?

Thanks,
Sandy

[1] http://automorphic.blogspot.com/2008/09/toward-more-clickable-banshee-ive.html
(please note that behavior has improved a lot since this post)
[2] http://bugzilla.gnome.org/show_bug.cgi?id=428849
[3] http://bugzilla.gnome.org/attachment.cgi?id=136043&action=view


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]