Re: [Banshee-List] banshee r4800 - in trunk/banshee: . src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor

["Gabriel Burt" <gabriel burt gmail com>]

That's certainly not my intention, and if Alex or others feel that
way, I'm very sorry.

Your point about string freezes is valid, but there were other
problems with the commit that would have been worked out had it been
filed as a bug and been reviewed - and I don't think that's too much
to ask for a first-time committer to Banshee.   Most importantly, I
just wanted to make sure we're all on the same page.  Our processes
and conventions help make Banshee a great project, but only if they're
followed.

Alex, ymposter, everybody: I sincerely hope you don't see unnecessary
barriers to contributing to Banshee and free software in general.  I
honestly want your help and want to help you get involved.  I welcome
constructive criticism or suggestions to that end.

Thanks,

Gabriel

On Sat, Nov 8, 2008 at 1:15 PM, ympostor <ympostor clix pt> wrote:
>
> Why don't you stop burning out your contributors?
>
> First, forcing them to the process of opening a bug, creating a patch
> and waiting for the review is non-sense for a change like this.
>
> Second, a string addition to L10N doesn't affect string freeze because
> it's an *addition*, not a modification. That is, translations that don't
> get updated won't have the string, just as like if the fix hadn't ever
> been committed.
>
>
>
> Gabriel Burt wrote:
>> Hi Alex,
>>
>> Thanks for catching this, but it would have been more appropriate to
>> file a bug and submit a patch, as per our code contribution guidelines
>> [1], or at least to have asked a maintainer (Aaron or myself) before
>> committing.  We might have been in the middle of a string freeze or
>> making a release.  You should also try compiling with any patches you
>> contribute (and most certainly ones you commit); this one broke the
>> build.  Also, please follow our convention for svn log messages
>>
>> Thanks,
>>
>> Gabriel
>>
>> [1] http://banshee-project.org/contribute/write-code/
>>
>> On Fri, Nov 7, 2008 at 4:04 PM,  <aprokoudine svn gnome org> wrote:
>>> Author: aprokoudine
>>> Date: Fri Nov  7 22:04:46 2008
>>> New Revision: 4800
>>> URL: http://svn.gnome.org/viewvc/banshee?rev=4800&view=rev
>>>
>>> Log:
>>> marked messahe for translation
>>>
>>>
>>> Modified:
>>>   trunk/banshee/ChangeLog
>>>   trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs
>>>
>>> Modified: trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs
>>> ==============================================================================
>>> --- trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs        (original)
>>> +++ trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs        Fri Nov  7 22:04:46 2008
>>> @@ -131,7 +131,7 @@
>>>                     }
>>>                 }
>>>
>>> -                AddItem ("Container Formats:", file.TagTypes.ToString ());
>>> +                AddItem (Catalog.GetString ("Container Formats:", file.TagTypes.ToString ()));
>>>                 AddSeparator ();
>>>             }
>>>
>>> _______________________________________________
>>> SVN-commits-list mailing list (read only)
>>> http://mail.gnome.org/mailman/listinfo/svn-commits-list
>>>
>>> Want to limit the commits to a few modules? Go to above URL, log in to edit your options and select the modules ('topics') you want.
>>> Module maintainer? It is possible to set the reply-to to your development mailing list. Email svnmaster gnome org if interested.
>>>
>
>
> _______________________________________________
> banshee-list mailing list
> banshee-list gnome org
> http://mail.gnome.org/mailman/listinfo/banshee-list
>