Re: [Banshee-List] banshee r4800 - in trunk/banshee: . src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor

["Gabriel Burt" <gabriel burt gmail com>]

Hi Alex,

Thanks for catching this, but it would have been more appropriate to
file a bug and submit a patch, as per our code contribution guidelines
[1], or at least to have asked a maintainer (Aaron or myself) before
committing.  We might have been in the middle of a string freeze or
making a release.  You should also try compiling with any patches you
contribute (and most certainly ones you commit); this one broke the
build.  Also, please follow our convention for svn log messages

Thanks,

Gabriel

[1] http://banshee-project.org/contribute/write-code/

On Fri, Nov 7, 2008 at 4:04 PM,  <aprokoudine svn gnome org> wrote:
> Author: aprokoudine
> Date: Fri Nov  7 22:04:46 2008
> New Revision: 4800
> URL: http://svn.gnome.org/viewvc/banshee?rev=4800&view=rev
>
> Log:
> marked messahe for translation
>
>
> Modified:
>   trunk/banshee/ChangeLog
>   trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs
>
> Modified: trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs
> ==============================================================================
> --- trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs        (original)
> +++ trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/StatisticsPage.cs        Fri Nov  7 22:04:46 2008
> @@ -131,7 +131,7 @@
>                     }
>                 }
>
> -                AddItem ("Container Formats:", file.TagTypes.ToString ());
> +                AddItem (Catalog.GetString ("Container Formats:", file.TagTypes.ToString ()));
>                 AddSeparator ();
>             }
>
> _______________________________________________
> SVN-commits-list mailing list (read only)
> http://mail.gnome.org/mailman/listinfo/svn-commits-list
>
> Want to limit the commits to a few modules? Go to above URL, log in to edit your options and select the modules ('topics') you want.
> Module maintainer? It is possible to set the reply-to to your development mailing list. Email svnmaster gnome org if interested.
>