Re: [Banshee-List] More ListView Performance Goodness!

["Aaron Bockover" <abockover novell com>]

Nice. Also, you have list_canvas and list_canvas_b. It looks strange
(text alignment). Mind calling list_canvas something like list_canvas_a.
Or even better, change a and b to describe their use? Descriptive
variable names are quite helpful, even if they sometimes get long.

</nitpick>

--Aaron

On Tue, 2008-02-12 at 11:15 -0500, Scott Peterson wrote:
> > After just a quick scan of the patch, it seems like the logic for "If
> > new rows have come into view at the bottom" and "If new rows have come
> > into view at the top" can be merged. The code here is somewhat large and
> > nearly identical.
> 
> That was the optimization for which I was considering getting out of
> bed, turning on my computer, and making last night :). Done and in
> http://homepages.nyu.edu/~stp225/listview2.patch
> _______________________________________________
> Banshee-list mailing list
> Banshee-list gnome org
> http://mail.gnome.org/mailman/listinfo/banshee-list