Re: [Banshee-List] More ListView Performance Goodness!



Hi,



On Mon, 2008-02-11 at 22:12 -0500, Scott Peterson wrote:
> And here is the patch which fixes all of the bug I know about. I'd
> like to hold off on committing until some other people (abock?) get a
> chance to review/test this. Inline FTW!
> 
> Index: src/Core/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Windowing.cs
> ===================================================================
> --- src/Core/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Windowing.cs	(revision
> 3222)
> +++ src/Core/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Windowing.cs	(working
> copy)
> @@ -184,6 +186,11 @@
>              list_window.Destroy ();
>              list_window = null;
> 
> +            list_canvas.Dispose ();
> +            list_canvas = null;
> +            list_canvas_b.Dispose ();
> +            list_canvas = null;
> +
>              base.OnUnrealized ();
>          }

I guess you meant the following in the fourth added line :

  +            list_canvas_b = null;

This jumped at me while reading your e-mail, I haven't applied your
patch.

Regards,

-- 
Bertrand Lorentz <bertrand lorentz gmail com>
> http://flickr.com/photos/bl8/ <

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]