Re: [Banshee-List] A small bug in src/Plugins/Banshee.Plugins.NotificationAreaIcon/NotificationAreaIconPlugin.cs

["Josiah Ritchie" <josiah ritchie gmail com>]

On 11/2/07, Gregoire Gentil <gregoire gentil com> wrote:

Hello,

There is a small bug in the notification plugin. If you close Banshee
with the notification turned on and the main window is not visible (so
you close through the window manager for instance), the window is
restored instead of hidden.

The reason is that there has been a confusion between
MainWindow.IsActive and MainWindow.Visible. A window can be active
without being visible. Read the patch below.

Cheers,

Grégoire



---
banshee-20071013-orig/src/Plugins/Banshee.Plugins.NotificationAreaIcon/NotificationAreaIconPlugin.cs    2007-10-27 17:02:12.000000000 -0700
+++
banshee-20071013/src/Plugins/Banshee.Plugins.NotificationAreaIcon/NotificationAreaIconPlugin.cs 2007-10-27 17:02: 01.000000000 -0700
@@ -241,7 +241,7 @@

         private void ShowHideMainWindow()
         {
-            if (InterfaceElements.MainWindow.IsActive) {
+            if (InterfaceElements.MainWindow.Visible ) {
                 SaveWindowSizePosition();
                 InterfaceElements.MainWindow.Visible = false;
             } else {

Thanks for pointing this out and including a patch. The banshee way of dealing with bugs and patches is briefly documented here: http://banshee-project.org/Bugs. Basically, if you report it at http://bugs.gnome.org, you'll get it into the regular process of bug response so that this patch doesn't get lost in the shuffle. http://bugzilla.gnome.org/browse.cgi?product=banshee will give you even more detail on what's going on with banshee bugs.

JSR/

-- 
Our Mission
Technology and Hospitality for God's Workmen
http://missions.ritchietribe.net