[Banshee-List] A small bug in src/Plugins/Banshee.Plugins.NotificationAreaIcon/NotificationAreaIconPlugin.cs


There is a small bug in the notification plugin. If you close Banshee
with the notification turned on and the main window is not visible (so
you close through the window manager for instance), the window is
restored instead of hidden.

The reason is that there has been a confusion between
MainWindow.IsActive and MainWindow.Visible. A window can be active
without being visible. Read the patch below.



banshee-20071013-orig/src/Plugins/Banshee.Plugins.NotificationAreaIcon/NotificationAreaIconPlugin.cs	2007-10-27 17:02:12.000000000 -0700
banshee-20071013/src/Plugins/Banshee.Plugins.NotificationAreaIcon/NotificationAreaIconPlugin.cs	2007-10-27 17:02:01.000000000 -0700
@@ -241,7 +241,7 @@
         private void ShowHideMainWindow()
-            if (InterfaceElements.MainWindow.IsActive) {
+            if (InterfaceElements.MainWindow.Visible) {
                 InterfaceElements.MainWindow.Visible = false;
             } else {

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]