Re: [Patch] move to libical

Hi Albrecht!

On 01/19/2020 10:01:30 AM Sun, Albrecht Dreß wrote:
Hi all,

finally, I have a patch ready which uses libical for displaying text/calendar parts in Balsa.  The old code 
was /very/ limited and had almost no capabilities for displaying complex requests.

Although the new implementation eliminates the code for scanning the events, I added a few more fields from 
the events as well as a *lot* of code for decoding recurrence rules which may be *very* complex (compare RFC 
5545, Sect. 3.3.1).  Actually, I implemented most of this stuff (which amounts to ~½ of libbalsa/rfc2445.c) 
as in Thunderbird's Lightning extension, so I /hope/ it covers most common cases.  I have a bunch of test 
messages, created in Thunderbird, to demonstrate parsing, just let me know if you would like to check them 
(or try yourself…).

Thanks for the patch! At over 2000 lines, that's a lot of work😁️

I've applied it to master and I'm using it now. I have a few "iTIP calendar Event Request" messages, and they 
look fine. But they're not complex, so that's a low bar! I expect your tests are more rigorous.

The patch applies to both the master and the gmime3 branches (the latter seems to be somewhat behind master, 

Ahh, yes--I just rebased gmime3 on master, and will do so again after committing this patch.

As always, any comment is welcome!


Thanks again,


Attachment: pgpFuB0woQ5sm.pgp
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]