Re: [Patch] Fix progress dialogue on error (Was: Good news)

Hi Albrecth,

On 2018.01.07 07:42, Albrecht Dreß wrote:
Hi Jack:

Thanks a lot for testing, and for your feedback!

Am 07.01.18 00:39 schrieb(en) Jack:
The only actual remaining issue with this patch, then, is that if a mailbox fetch gets a "Socket I/O timed out" error, the entry for that mailbox is not removed from the dialog. (Clearly, just hitting the "Hide" button is an adequate workaround.") A minor annoyance, perhaps, but not really serious.

Thanks! A stupid bug, not sending the “finalise” notification to the dialogue if opening the connection fails. Trivial patch is attached…
Unfortunately, it doesn't seem to work. (Identical results with autotools and meson builds). I changed one of the yahoo servers to TLS, wait for the timeout, get the popup error, "Check" button re-enabled, but progress dialog remains showing with that one server.

Albrecht - thanks for all the work on this, and sorry for all the interim problems in getting through it.

You're welcome. The issues you reported are clearly an indication that we have to review the (out-of-source?) build processes and the user documentation…
And it was pointed out to me recently that there are two different possibilities for out of source builds. One is with the build dir completely outside the source dir. The other is with the build dir somewhere under the top source dir. I don't think they need to be treated differently, but I not certain.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]