Re: Master is again the master

[Jack <ostroffjh users sourceforge net>]

On 2016.10.06 14:04, Jack wrote:
> On 2016.10.06 13:44, Albrecht Dreß wrote:
> > Am 06.10.16 03:21 schrieb(en) Peter Bloomfield:
> > > > - the spacing issue reported by Helmut  
> > > > (<https://mail.gnome.org/archives/balsa-list/2016-September/msg00002.html>)  
> > > > - no idea how complicated it is
> > > It seems to be a rendering issue in GtkTreeView--probably needs  
> > > someone with intimate knowledge of that widget to diagnose whether  
> > > it's an error in the way Balsa uses it, or an actual bug.

> > I also see this issue.  Some observations on my box:
> > - Playing with the TREE_VIEW_FIXED_HEIGHT setting in balsa-index.c  
> > does not help.
> > - Closing and re-opening the mailbox tab usually (?) restores equal  
> > row heights.
> I think I've seen this, and it seems that reading the message fixes  
> the header for that message.  It seems when the bold (for unread) is  
> removed, it might trigger some other change in the widget, which  
> "fixes" the height.
I don't see this problem now, but it was never consistent for me, and I  
have not detected any pattern of when it did happen.

> > Some other issues I see in the mail list view when starting Balsa  
> > with a number of open mailbox tabs:
> > - When Balsa downloads a large number of messages from POP3 (>100)  
> > which are fed through procmail, in some mailboxes only a few  
> > messages (say, 10, all new ones) are in the list.  This doesn't  
> > happen if fewer messages are loaded.  Closing and re-opening  
> > displays the full list (~1000 messages) properly.
> I haven't seen that, but I don't think I've ever downloaded over 100  
> messages in one go.  Also, I use popfile (spam filter) and not  
> procmail.
> > - Rarely threading and/or sorting isn't applied on startup -  
> > messages just appear in random order and/or without threading.   
> > Again, closing and re-opening helps (or re-sorting or changing the  
> > threading mode).

> > Anyone else saw similar effects?
> I have JWZ threading selected, and I'm pretty sure whenever I open a  
> (maildir) mailbox, the messages are all in  message number order.  I  
> think we discussed this in the past, and that seems to be the order  
> in which the message files are read - probably set by the file system  
> when Balsa just iterates through all files in the directory.  If I  
> click on the Date column header twice, it correctly sorts and applies  
> the threading.
I just finished compiling from the new and improved git master head.   
Wow!  Opening my largest mailbox is now almost instant (previously ten  
to twenty seconds - not horrible but annoying) and threading is correct  
as soon as it opens.

> > > I get the sense that GtkTreeView no longer gets much attention from  
> > > the Gtk folks. We could look for a different way to present the  
> > > message list using other widgets, but with a different look. That  
> > > may have a longer time line than we would want for a 2.5.3 release.
> >
> > I fully agree with you.  IMO, all the effects above are *not*  
> > show-stoppers!
> >
> > > > - Readme and Install instructions
> > >
> > > Patches welcome!
> >
> > I added some changes to README and AUTHORS (which need review), but  
> > these files /should/ now reflect the current status...  Is there  
> > really any important information in INSTALL which is not in README?   
> > If not, we just might replace INSTALL with the standard file coming  
> > with the autoconf package.
> >
> > > > - anything else?  I would still appreciate a consistent coding  
> > > > style, but that can definitely wait until after a new release!
> > >
> > > OK--it doesn't look like we can find a tool for mass reformatting  
> > > of the code that would give results that anyone would be satisfied  
> > > with. We may have bigger issues lurking in some of the older code  
> > > than format!
> >
> > Yes, that's of course right!  We can keep that in mind, maybe some  
> > day a better tool is available...
> >
> > Cheers,
> > Albrecht.
Jack