Hi Albrecht, On 06/04/2016 09:57:26 AM Sat, Albrecht Dreß wrote:
Hi all,
attached is a (somewhat unsorted) patch containing the following fixes/improvements:
(1) libbalsa/html.c: with my patch removing deprecated stuff [1] I forgot to delete the Gtkhtml2 parts...
(2) We *always* use gtksourceview-3.0, so we can
- configure.ac: clean up setting the #define
- Makefile.am: store helper files in a properly named folder
- libbalsa/libbalsa.c: clean up, use proper helper files folder
- src/balsa-mime-widget-text.c, src/sendmsg-window.c: clean up
(3) configure.ac, libbalsa/html.c: as Webkit does not have a method to convert html to text, we cannot quote
html-only messages. As a workaround, try to use html2text
(4) libbalsa/files.c: force proper icon sizes (e.g. in the message structure view)
Opinions?
Thanks for the contributions! To test the html2text part, I installed it with "dnf install html2text", which actually installed the python-html2text package, and a script of the same name, but no script named html2text (nor a sym-link). Is that the same tool you used under a different name, or is your tool something different? I changed AC_PATH_PROG to AC_PATH_PROGS and added python-html2text to the list, and it seems to work. Does that seem right to you? Best, Peter
Attachment:
pgp2D_qPCPBMf.pgp
Description: PGP signature