Fixed! (was: I have an email that crashes balsa when view-all headers is selected)


the reason for this crash is that embedded messages which are not displayed (i.e. they do not have a "disposition-type: inline" set explicitly) in turn do not have a headers widget, and the check for that is missing in balsa-message.c, function balsa_message_set_embedded_hdr(). The fix for that is trivial, and should work with both 2.0 and 2.2:

--- balsa-message.c.orig        2004-09-24 20:50:18.000000000 +0200
+++ balsa-message.c     2004-09-25 15:16:02.000000000 +0200
@@ -1295,7 +1295,7 @@

    gtk_tree_model_get(model, iter, PART_INFO_COLUMN, &info, -1);
    if (info) {
-        if (info->body && info->body->embhdrs)
+        if (info->body && info->body->embhdrs && info->widget)
            display_embedded_headers(bm, info->body, info->widget);

BTW, we might want to disscuss whether embedded messages should default to "inline" unless being defined as "attachment" or not, but that's a different point.

Cheers, Albrecht.

Albrecht Dreß  -  Johanna-Kirchner-Straße 13  -  D-53123 Bonn (Germany)
      Phone (+49) 228 6199571  -  mailto:albrecht dress arcor de

Attachment: pgpOUR1KXEJ3U.pgp
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]