Re: Found the problem in the pop funtion but not the fix :-(

Whoops --

In self defense, I did send a 'fix' to this both seperately (to interested
parties about 2 days after the initial POP patch) and in my threads patch
here on the list. I'm sorry this made it into the first POP3 patch -- it
'stuck' to the CVS code, it seems, because of the temporary split between
the then frozen CVS development, and the patches that were being exchanged
here on the list.  The fix is as simple as checking for a NULL pointer, as
Peter points out.


On Fri, 22 Oct 1999, Peter Williams wrote:

> On Fri, 22 Oct 1999 19:09:02 Hector Garcia wrote:
> > Hi all
> > 
> > I have found why pop3 accounts didnīt work right
> > 
> > The Segmentation Fault I talked about in my previous letter is due to this line
> > 
> > if( strcmp( MAILBOX_POP3(mailbox)->last_popped_uid, uid )
> > 
> > (gdb) print ((MailboxPOP3 *)(mailbox))->last_popped_uid
> > $3 = 0x0
> Thanks for the information. This means that last_popped_uid is a null pointer, and strcmp() will
> try to dereference and segfault. The last_popped_uid is I believe added in the threading patch,
> you will have to talk to the author (is David Pickens the name? I'm afraid I forget) about it.
> The problem about working Balsa now is we're all waiting with bated breath for Stuart's updates
> to Balsa which seem to be fairly major changes that will probably break any patches we try. OTOH,
> Stuart assures us that the updated code 'will not suck' so maybe there will be no need to fix 
> anything.
> ==============================
> Peter Williams
> -- 
> 	FAQ: Frequently-Asked Questions at
>          To unsubscribe: mail with 
>                        "unsubscribe" as the Subject.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]