Re: [anjuta-devel] Some Patches

[Sébastien Granjoux <seb sfo free fr>]

Hi,


Le 24/12/2011 08:50, Arnel A. Borja a écrit :
> I also have 3 additional patches, and another one
> I added to bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=666790

I don't see any attachment in this bug report.

> The first patch
> (0001-project-wizard-Use-pkgdatadir-instead-of-datadir-pac.patch) is
> necessary for the previous patches already committed.

Ok, I will commit it.


> The second
> (0002-project-wizard-Move-PROJECT_CFLAGS-to-own-line-in-mi.patch) is
> addition to a previous patch that is also committed already,

Ok.


> and the
> last (0003-project-wizard-check-HavePackage-before-adding-PROJE.patch)
> is unnecessary, but you may want to commit this if you want consistency
> across the other templates (the templates will still work even without
> this).

Ok.


> The one in GNOME Bugzilla is to fix the value of NameHLower in
> templates, assuming that:
> - NameCUpper is "Name converted to C-String, uppercase"
> - NameCLower is "Name converted to C-String, lowercase"
> - NameCClass is "Name converted to C-String, camelcase"
> - NameHLower is "Name but use hyphens, lowercase"
> because I'm not sure if that's what they mean, NameHLower is sometimes
> used in place of NameCLower (C Library template) and NameCClass (Anjuta
> Plugin template). This will fix the bug that hyphens in filenames are
> replaced with underscores, by removing the c-string filter (not sure if
> it's called a filter).

It's not very important, in order to make things a bit nice, NameHLower 
could be used instead of NameCLower to keep hyphens when it's possible, 
in file name typically. Currently only space are replaced by hyphens. 
The issue with removing the c-string filter, is that you will keep some 
other characters that you don't want like slash, backslash and all 
special characters.


Regards,

Sébastien