[anjuta-devel] Some Patches



I have some patches that I want to be included in Anjuta, but I'm not sure if I should create a bug in Bugzilla or just use the Mailing Lists. I also want to know you're opinion on these:

0001: build-basic-autotools: Remove --enable-maintainer-mode from defaults
-----
Since project-wizard no longer uses AM_MAINTAINER_MODE, I think this option should be removed from the default arguments to configure. Some warnings will be shown if this will not be removed, one of them saying that it's an unknown argument.

0002: anjuta-build-tutorial: Remove AM_MAINTAINER_MODE
-----
Since AM_MAINTAINER_MODE is no longer used in project-wizard, it is no longer necessary to discuss this in the tutorial. It will only confuse new users, showing information that is unnecessary to understand creation of basic projects in Anjuta.

0003: class-gen: Use convention for get-private macros
-----
GObjects are commonly have a macro to get the private data related to it. They are commonly named "[PREFIX]_[SUFFIX]_GET_PRIVATE". But class-gen uses "[PREFIX]_[SUFFIX]_PRIVATE", which is wrong; it will mislead the user thinking that the macro is supposed to cast a pointer to a certain private data, just like what GTK_TREE_MODEL, G_OBJECT, etc.

0004: project-wizard: Use Automake variables for defines
-----
Templates in project-wizard unnecessary recreate the value of localedir, while PACKAGE_DATA_DIR is misleading; instead of using $(pkgdatadir) to point to a package's data dir, it uses $(datadir) which points to the system's data dir.

0005: project-wizard: Move PROJECT_CFLAGS to own line
-----
Unnecessary, but may help to make reading Makefiles easier.

0006: project-wizard: Don't symlink Automake files
-----
Using symlink (the default) instead of copy poses the risk of adding files to version control without their contents. So, when a user that uses a different operating system or Linux distro pulls from git/svn/etc: *BOOM*.

Attachment: 0001-build-basic-autotools-Remove-enable-maintainer-mode-.patch
Description: Text Data

Attachment: 0002-anjuta-build-tutorial-Remove-AM_MAINTAINER_MODE.patch
Description: Text Data

Attachment: 0003-class-gen-Use-convention-for-get-private-macros.patch
Description: Text Data

Attachment: 0004-project-wizard-Use-Automake-variables-for-defines.patch
Description: Text Data

Attachment: 0005-project-wizard-Move-PROJECT_CFLAGS-to-own-line.patch
Description: Text Data

Attachment: 0006-project-wizard-Don-t-symlink-Automake-files.patch
Description: Text Data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]