Re: [anjuta-devel] Some Patches

["Arnel A. Borja" <kyoushuu yahoo com>]

On Friday, 23 December, 2011 06:24 AM, Johannes Schmid wrote:
> > 0006: project-wizard: Don't symlink Automake files
> > -----
> > Using symlink (the default) instead of copy poses the risk of adding
> > files to version control without their contents. So, when a user that
> > uses a different operating system or Linux distro pulls from
> > git/svn/etc: *BOOM*.
> Generated files shouldn't ever be in version control, right?
>
> Regards,
> Johannes
I just noticed that some projects adds "INSTALL" to their repositories, 
which is symlinked by automake when the project is created.


Also, thanks to Sébastien Granjoux and Johannes Schmid for reviewing and 
committing my patches. I also have 3 additional patches, and another one 
I added to bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=666790

The first patch 
(0001-project-wizard-Use-pkgdatadir-instead-of-datadir-pac.patch) is 
necessary for the previous patches already committed. The second 
(0002-project-wizard-Move-PROJECT_CFLAGS-to-own-line-in-mi.patch) is 
addition to a previous patch that is also committed already, and the 
last (0003-project-wizard-check-HavePackage-before-adding-PROJE.patch) 
is unnecessary, but you may want to commit this if you want consistency 
across the other templates (the templates will still work even without 
this).

The one in GNOME Bugzilla is to fix the value of NameHLower in 
templates, assuming that:
- NameCUpper is "Name converted to C-String, uppercase"
- NameCLower is "Name converted to C-String, lowercase"
- NameCClass is "Name converted to C-String, camelcase"
- NameHLower is "Name but use hyphens, lowercase"
because I'm not sure if that's what they mean, NameHLower is sometimes 
used in place of NameCLower (C Library template) and NameCClass (Anjuta 
Plugin template). This will fix the bug that hyphens in filenames are 
replaced with underscores, by removing the c-string filter (not sure if 
it's called a filter).

Attachment: 0001-project-wizard-Use-pkgdatadir-instead-of-datadir-pac.patch
Description: Text Data

Attachment: 0002-project-wizard-Move-PROJECT_CFLAGS-to-own-line-in-mi.patch
Description: Text Data

Attachment: 0003-project-wizard-check-HavePackage-before-adding-PROJE.patch
Description: Text Data