Re: [anjuta-devel] git-shell branch

[James Liggett <jrliggett cox net>]

On Sun, 2010-11-14 at 23:14 +0100, Abderrahim KITOUNI wrote: 
> Hi all,
>
> I've also recently tried the git shell branch and I like it. I feel
> the UI is a bit too cluttered but the idea is good. Having items
> (dis)appear or become (un)sensitive as I (de)select things would be a
> plus, though.
To be honest I'm not a fan of hiding things. Originally this was
something I considered, but the more I thought about it the more
concerned I became about users being confused because commands would
appear/disappear for no obvious reason.

OTOH, making things insensitive seems reasonable. Part of the reason git
shell doesn't do it now is that I'm just being lazy. :) But all of the
pieces are in place to make it happen.

Thanks for testing,
James 
> 2010/11/14 Johannes Schmid <jhs jsschmid de>:
> > Hi James!
> >
> > I just took a look at the git shell branch and I think it works out
> > really nice. Don't you think it would be a good point to merge it into
> > master? I couldn't find anything that's not working though of course
> > some features are missing but they can be added later on (git am, git
> > bisect came to my mind).
> I also think it's fine to merge it now, there are still some little
> bugs, but nothing that should block merging.
>
>
> > Some small things I found that I consider bugs:
> I'll add some of my own:
> * It seems to refresh the status of the working dir every second or so
> (the display is cleared and reshown every time).
> I think this is caused by the fact that running 'git status' touches
> .git/index which triggers another update.
> * It doesn't support working with a detached HEAD (not that this is an
> often used feature ...), It won't let me checkout a remote branch
> (really, the checkout button should be unsensitive when it cannot do
> it rather than doing nothing) and I get an error message on startup
> saying: "ambiguous argument '(no branch)': unknown revision or path
> not in the working tree." (it's clearly trying to pass the "(no
> branch)" output of git branch to git log.
>
> > * Log viewer freezes anjuta for some seconds here, I think it should be
> > async
> I don't see this here, maybe I'm just using some "small" repository.
>
> > I am not 100% sure if it is useful to show the "Push" and "Pull" tab (or
> > basically any other) at the same time. I was a bit confusing to me and I
> > felt it would be easier if the "Push" tab just closed the "Pull" tab an
> > veci versa.
> Yes, I agree. I feel like these shouldn't be tabs in the first place.
> Also try to make sure panes don't get too big (I'm using a 17" monitor
> and I often see scrollbars, so someone using a laptop wouldn't get a
> nice experience).
>
> > Thanks for all the work you put into that branch!
> Yes, thanks James :-)
>
> Cheers,
> Abderrahim
>
> P.S. sorry if I don't make sense, it's late here :-)