On Mon, Sep 17, 2012 at 12:28:37AM +0300, Roumen Petrov wrote: > Hi Thierry, > > > Thierry Reding wrote: > >On Sun, Sep 16, 2012 at 06:33:37PM +0300, Roumen Petrov wrote: > >>Thierry Reding wrote: > >>>[SNIP] > >>> configure.ac | 716 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > >>> configure.in | 715 ---------------------------------------------------------- > >>>[snip] > >>It is not possible to follow updates with such patch. > >>Why do not keep as is and to left to Daniel to rename in the future ? > >I should have generated this with git format-patch -M, that would have > >detected the rename. I can resend if necessary. > > No idea how git handle file rename send in patch file. On PC with > repository I have "ancient" git 1.6.4 and you patch may is not > suitable for this version. > > Based on you change in Makefile.am I guest that you would like to > propose something like "0012-libtool-2-rules.patch". Such change was > not acceptable before recently updates, .i.e configure script is > with LT_INIT. Yes, that's part of what the patch does. It also updates AC_INIT and AM_INIT_AUTOMAKE usage because recent autotools are starting to complain. > Also those days I note that libxslt use own INSTALL file and this > require AUTOMAKE_OPTIONS = foreign to be added to toplevel > Makefile.am and this explain why is not in attached file. That should be taken care of by my patch as well. It passes the foreign option to AM_INIT_AUTOMAKE so you don't have to list it in Makefile.am. > Please could to send configure diff separately . It will be more > easy to review. I just resent the patch with rename detection enabled so it is easier to see what was changed. Thierry
Attachment:
pgpwBUtZ41pAB.pgp
Description: PGP signature