Re: [xslt] [PATCH 1/3] Modernize configure script

[Roumen Petrov <bugtrack roumenpetrov info>]

Hi Thierry,


Thierry Reding wrote:
> On Sun, Sep 16, 2012 at 06:33:37PM +0300, Roumen Petrov wrote:
> > Thierry Reding wrote:
> > > [SNIP]
> > >   configure.ac | 716 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >   configure.in | 715 ----------------------------------------------------------
> > > [snip]
> > It is not possible to follow  updates with such patch.
> > Why do not keep as is and to left to Daniel to rename in the future ?
> I should have generated this with git format-patch -M, that would have
> detected the rename. I can resend if necessary.

No idea how git handle file rename send in patch file. On PC with 
repository I have "ancient" git 1.6.4 and you patch may is not suitable 
for this version.

Based on you change in Makefile.am I guest that you would like to 
propose something like "0012-libtool-2-rules.patch". Such change was not 
acceptable before recently updates, .i.e configure script is with LT_INIT.

Also those days I note that libxslt use own INSTALL file and this 
require AUTOMAKE_OPTIONS = foreign to be added to toplevel Makefile.am 
and this explain why is not in attached file.


Please could  to send configure diff separately . It will be more easy 
to review.

> Thierry

Roumen

>From a20840c85a70524d866fdb69de46c00a44a1515b Mon Sep 17 00:00:00 2001
From: Local <local example net>
Date: Fri, 11 Nov 2011 23:39:40 +0200
Subject: [PATCH 12/13] libtool 2+ rules

---
 .gitignore   |    5 +++++
 Makefile.am  |    2 ++
 configure.in |    2 ++
 3 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/.gitignore b/.gitignore
index 750ec30..23796b8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -148,3 +148,8 @@ tests/plugins/.libs
 tests/plugins/plugin.res
 xsltproc/testThreads
 xsltproc/.libs/
+m4/libtool.m4
+m4/lt~obsolete.m4
+m4/ltoptions.m4
+m4/ltsugar.m4
+m4/ltversion.m4
diff --git a/Makefile.am b/Makefile.am
index e357f19..6e16cf1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,3 +1,5 @@
+ACLOCAL_AMFLAGS = -I m4
+
 SUBDIRS = \
 	libxslt \
 	libexslt \
diff --git a/configure.in b/configure.in
index 1e4b8bb..9d783f2 100644
--- a/configure.in
+++ b/configure.in
@@ -2,6 +2,8 @@ dnl Process this file with autoconf to produce a configuration script.
 AC_PREREQ(2.59)
 AC_INIT(libxslt/xslt.c)
 AC_CONFIG_HEADERS(config.h)
+AC_CONFIG_MACRO_DIR([m4])
+
 AC_CANONICAL_HOST
 AC_USE_SYSTEM_EXTENSIONS
 
-- 
1.6.4