Re: [xslt] win32 build (mingw-cross compilation)

[Daniel Veillard <veillard redhat com>]

On Fri, Aug 24, 2007 at 07:00:06PM +0300, Roumen Petrov wrote:
> Also note difference between builds process in case of cross compilation
> and native build when mingw gcc compiler is used. First use GNU auto-tools
> but second plain makefile-win32/Makefile.mingw. So that my short patch
> doesn't affect other builds.

Cygwin for example use those.
Plus you changed code within _WIN32 sections in the C code regardless of
the compiler used at that point as I pointed out in my reply. You can't
do that.

> Before to discuss more details for general patch, please could someone
> point why winsock should be used in libxslt ?

The patch should be a portability patch, if there are others problems
make separate patches which can be examined separately. You can't just
say 'here is a mingw-cross compilation patch' and change the behaviour
for other compilers.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/