Re: [xslt] libxslt won't compile under cygwin

[Thomas Broyer <tbroyer ltgt net>]

Le 13/09/01 07:27:38, Justin Fletcher a écrit :
> > Does libexslt/date.c compiles and does the platform have the time()
> 
> Initially, yes. Because neither HAVE_TIME, nor HAVE_GMTIME were
> defined...
> 
> This is, I guess a reasonable test that if time components aren't
> available things still work... the following warnings were thrown up
> (amongst others which mostly relate to narrowing casts) :
> 
> "c.date", line 591: Warning: inventing 'extern int memset();'
> "c.date", line 2169: Warning: static 'exsltDateDateTime' declared but not
> used
> "c.date", line 2169: Warning: static 'exsltDateFormatDateTime' declared
> but not used
> 
> They're not that important. The memset just means you need to include
> <stdlib.h>

Hmm, I thought I fixed it just before the release...

> Once HAVE_TIME and HAVE_GMTIME were defined, WITH_TIME becomes active in
> libexslt, and the latter two of those errors go away.

I know.

> Minor thing:
> 
> exsltDateCurrent calls :
> 
>     ret = exsltDateCreateDate();
> 
> But does not check that ret is valid before assigning to it a couple of
> lines later.

Thanks, I'll fix it.

> More importantly:
> 
> #define VALID_MDAY(dt)						\
> 	(((dt->mon == 2) && !IS_LEAP(dt->year) && (dt->day <= 28)) ||\
> 	 (dt->day == daysInMonth[dt->mon - 1]))
> 
> should say :
> #define VALID_MDAY(dt)						\
> 	(((dt->mon == 2) && !IS_LEAP(dt->year) && (dt->day <= 28)) ||\
> 	 (dt->day <= daysInMonth[dt->mon - 1]))
> 
> otherwise VALID_MDAY is only valid in February and on the last day of the
> month.
> 
> ... and now I get valid information out of it :-)

Doh!!!

I just notice I was using 1999-05-31 (copy/paste'd from the XML Schema
spec) for my tests...

Will fix.

Thanks for the report!

Tom.