Re: [xslt] libxslt-1.0.1 is released

[Daniel Veillard <veillard redhat com>]

On Thu, Jul 26, 2001 at 04:49:31AM +0200, Thomas Broyer wrote:
> Here are some tests I made:
> 
> I made some minor changes to gnome-xml/xpath.c and
> libxslt/libxslt/variables.c:
>  · changed from xmlFreeNodeList to xmlFreeDoc in xmlXPathFreeValueTree
>  · changed from xmlCopyNode to xmlCopyDoc in xmlXPathObjectCopy
>  · changed from xmlNewDocNode to xmlNewDoc in xsltEvalVariable and
>    xsltEvalGlobalVariable

  Hum ... if this doesn't break other stuff, commit please.

> There was then a problem (at least) in xsltForEach, which calls
> xsltFindDocument (which doesn't find the document, of course).
> So I commented out the call to xsltFindDocument and replaced it with
> ctxt->document = list->nodeTab[i]->doc->doc.

  Assuming that you check first that it's the specific case of a value
tree fine, otherwise William clearly spent quite some time to fix this
area and this should be reviewed :-)

> Then there was a problem in xsltApplyStylesheetInternals when it calls
> xmlXPathFreeNodeSet(ctxt->nodeList), so I commented out this line.

  This doesn't sounds wise do you compile with memory debug enabled ?
I strongly suggest you do so in order to catch any memory leak before
comminting this kind of changes.

> My XSLT test file (see below) works almost well.

  Well commit your test cases and integrate them with the build system.

> The last, commented lines do not work and produce weird chars: there's a
> problem with the XPath evaluation (most probably a problem while setting up
> the XPath context)
> 
> Hope these little, simple tests will help...

  In this case no because you didn't committed your recent changes so
it seems I would debug a different code, right ?

Daniel

-- 
Daniel Veillard      | Red Hat Network http://redhat.com/products/network/
veillard@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Sep 17-18 2001 Brussels Red Hat TechWorld http://www.redhat-techworld.com