Re: [xslt] Proposed enhancement to some libxslt-0.6.0 routines

[Daniel Veillard <veillard redhat com>]

On Tue, Mar 27, 2001 at 10:26:10AM -0800, William M. Brack wrote:
> We have encountered a few problems with the current library.

  Okay I finally had time to look at it.

> 1) apply-template with parameter is not correct

  I think I finally understood what was needed there, I applied your patch
but had to change xsltApplyTemplates() because when new variable are 
added when calling the evaluation, they are added at the beginning of the
list.

> 2) there are major problems with the position() and last() functions

  Applied too,

> 3) the "base" path of the document() function should be interpreted relative to the URI of the stylesheet
> If our interpretation of the spec is correct, a small enhancement to functions.c fixes this problem.

   this sounds correct but I'm a bit worried that some of the pointer
dereferencing you added might break in some circumstance. But since it
was looking okay I didn't tried to secure them.

> these patches  change the results of some of the docbook tests, but we
> believe that the changed results are more correct (but not yet totally
> correct .....).

  yep I updated the result accordingly, once the memory leak was fixed
the regression tests were fine.

  thanks a lot for your patches !

Daniel

-- 
Daniel Veillard      | Red Hat Network http://redhat.com/products/network/
veillard redhat com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/