Re: [xml] Question about xmlDoc->oldNs usage in php

On 6/15/20 5:00 AM, Nick Wellnhofer wrote:
On 15/06/2020 05:04, Benjamin Eberlei wrote:
Now I am wondering what oldNs is even used for here, it seems from
the libxml code it is really only needed to "cache" a pointer to the
xmlNs that represents "xml" and nothing more.

No, the oldNs list is also appended to in `xmlDOMWrapStoreNs`. It
seems that this namespace list is only used for memory management.
From a quick look, your changes to the PHP code will cause a memory leak.



It will definitely create a memory leak and in a few  cases will cause
doc corruption


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]