Re: [xml] [PATCH] really declare dllexport/dllimport for Cygwin

[Nick Wellnhofer <wellnhofer aevum de>]

Thanks, patch applied here:

https://gitlab.gnome.org/GNOME/libxml2/commit/c65c9e8ee07e2dab0647392c2bd1795a5bc99829


On 25/05/2018 17:46, Michael Haubenwallner wrote:
> Cygwin does not define _WIN32, but still requires dllexport/dllimport
> tags for when applications use the --disable-auto-import linker flag,
> probably set by the gl_WOE32_DLL autoconf macro in woe32-dll.m4 file.
> ---
>   include/libxml/xmlexports.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/libxml/xmlexports.h b/include/libxml/xmlexports.h
> index 2c79f814..bc8a90d4 100644
> --- a/include/libxml/xmlexports.h
> +++ b/include/libxml/xmlexports.h
> @@ -131,8 +131,8 @@
>     #endif
>   #endif
>   
> -/* Cygwin platform, GNU compiler */
> -#if defined(_WIN32) && defined(__CYGWIN__)
> +/* Cygwin platform (does not define _WIN32), GNU compiler */
> +#if defined(__CYGWIN__)
>     #undef XMLPUBFUN
>     #undef XMLPUBVAR
>     #undef XMLCALL