Re: [xml] Patch to guard #define WIN32_LEAN_AND_MEAN



On 09/11/2017 15:33, Earnie wrote:
Testing for !defined(__CYGWIN__) here is meaningless.  _WIN32 isn't
defined in GCC with __CYGWIN__ defined and vice versa.

I think really old Cygwin versions used to set _WIN32 by default. See for example this thread from 1998:

    https://www.cygwin.com/ml/cygwin/1998-08/msg00569.html
    https://www.cygwin.com/ml/cygwin/1998-09/msg00002.html

I assume you're Earnie Boyd who also participated in this thread, so you probably know better than me. My guess is that's where the ubiquitous `defined(_WIN32) && !defined(__CYGWIN__)` idiom came from.

I'd be happy to remove all the `!defined(__CYGWIN__)` checks.

Nick



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]