Re: [xml] xmlXPathNodeSetSort performance



Rob Richards wrote:
This broke the win build (VS 2008 and below) as it doesn't contain stdint.h
Ok but this mean that VS 2010 and later contain this file, right ?

Outside on windows I don't have a system without stdint.h so can't completely test this change but assume it should be changes as follows (for consistency using same WIN32 define from dict.c):

#ifdef HAVE_STDINT_H
#include <stdint.h>
#else
#ifdef HAVE_INTTYPES_H
#include <inttypes.h>
#elif defined(WIN32)
typedef __int64 int64_t;
typedef unsigned __int64 uint64_t;
#endif
#endif

I think that definitions has to be protected by _MSC_VER since mingw* projects offer this file .
What about if _MSC_VER < xxxx (version for VS 2010)
typedef ....
#else
# define HAVE_STDINT_H
#endif

Also if defined(__MINGW32__) && !defined HAVE_STDINT_H
#define HAVE_STDINT_H
#endif

Later could by replaced by define in Makefile.mingw as configure based build will detect presence of this header file.


The windows defs do at least fix the win build

Rob

Roumen




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]