Re: [xml] Patch for xinclude bug 633166
- From: Daniel Veillard <veillard redhat com>
- To: Vitaly Ostanin <vitaly ostanin gmail com>
- Cc: xml gnome org
- Subject: Re: [xml] Patch for xinclude bug 633166
- Date: Fri, 17 Aug 2012 23:01:48 +0800
On Sun, May 27, 2012 at 12:40:51PM +0400, Vitaly Ostanin wrote:
Hello.
There are quite a long-standing problem in the code xinclude.c,
described in libxml2 bugzilla:
https://bugzilla.gnome.org/show_bug.cgi?id=633166
When you xinclude a text file, reading portions (by 4000 bytes) of the
buffer incorrectly handled the situation when the end comes across
portions of the bytes in a multibyte character.
I enclose a patch (also attached to the bugzilla bug report).
Please review the patch.
Looks reasonable, I had to tweak it a bit for 2.9.0 and
follwing existing coding practice but that looks like the right thing to
do. Thanks a lot for the patch :-) pushed upstream !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel veillard com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]