Re: [xml] xmlXPathNodeSetSort performance

[Stefan Behnel <stefan_ml behnel de>]

Stefan Behnel, 29.07.2012 06:55:
> Vojtech Fried, 26.07.2012 18:17:
> > Third version of the timsort patch. Unfortunately, I was not able to
> > finish it. It does not link on windows and I didn't test it in any way.
> > But if anyone wants to try it, it is probably not far away... I moved
> > the code to .c file and had to do some other shuffling.
>
> Hmm, it doesn't apply cleanly for me against 2.8.0 (so I guess you took it
> from the latest git master, which is the right thing to do). The only
> problem seems to be with the win32 setup, though, so I think I can safely
> ignore it.
>
> But once applied, it also doesn't build. The definition of the
> xmlNodeTimSort() function is missing.
>
> I tried your second patch and it works for me. Seeing how much more
> involved the third version of the patch is, I wonder if it's really all
> that bad to leave the timsort implementation in a header file. After all,
> it's supposed to be an externally maintained piece of code, and in the
> external repo, it lives in a header file. So it would reduce the
> maintenance overhead if it was just copied over unchanged.

Any comments? I think the second patch is ok as it stands.

Stefan