Re: [xml] [PATCH] Fix yet another --with-threads bug: using "pipe" instead of "logical OR"

On Tue, Oct 06, 2009 at 05:25:04PM +0300, Andrew W. Nosenko wrote:
Unfortunately, at the time of writing
    2bdf87e Restore behavior of --with-threads without argument

I was too concentrated on --with-threads without arguments and left
second problem in this check unattended: the test chain was built using
'|' pipe instead of '||' logical OR.

As consequence, case --with-threads=pthread remained broken, and
enabling threads by default become broken if neither --with-threads nor
--without-threads passed to configure at all.

* use '||' for "logical OR" operator as it should to be
instead of '|' (pipe).

  Ahhhh ! That's the reason ! I found a couple of suspicious warnings
about this but could not spot a problem on that line :(

Damn .... that's a nasty thing !


Daniel Veillard      | libxml Gnome XML XSLT toolkit
daniel veillard com  | Rpmfind RPM search engine | virtualization library

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]